salvage: fix ROS distance max_range mapping (credit @1aal #4908)#9781
Open
Bartok9 wants to merge 1 commit into
Open
salvage: fix ROS distance max_range mapping (credit @1aal #4908)#9781Bartok9 wants to merge 1 commit into
Bartok9 wants to merge 1 commit into
Conversation
) ROS1 airsim_ros_wrapper assigned sensor_msgs::Range::max_range from min_distance. Map max_range from max_distance instead. Document Range fields on airsim_ros_pkgs.md and fix a small spelling typo. Salvage of microsoft#4908 — original fix by @1aal; rebased onto current main with docs deckle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About
Salvage of #4908 by @1aal — credit to the original author.
ROS1
get_range_from_airsimsetsensor_msgs::Range::max_rangefromdist_data.min_distance, so max equalled min. Correct mapping ismax_distance.Enhancements beyond the original:
maindocs/airsim_ros_pkgs.mdROS2 wrapper already used
max_distance(left unchanged).Fixes
Files
ros/src/airsim_ros_pkgs/src/airsim_ros_wrapper.cppdocs/airsim_ros_pkgs.mdHow Has This Been Tested?
Notes
Aerial / drone agent campaign salvage slot for
microsoft/AirSim.